Remove unnecessary declarations

NSD
1

The following source files in the 4.1.3 tarball
declare extern int optind and extern char* optarg,
but those are already declared in the headers.
(Or is there a system where this is not the case?)

  Jan

diff -Nup -Nupr /tmp/nsd-4.1.13/nsd-checkconf.c /home/hans/src/nsd-4.1.13/nsd-checkconf.c
--- /tmp/nsd-4.1.13/nsd-checkconf.c Fri Aug 5 16:04:30 2016
+++ /home/hans/src/nsd-4.1.13/nsd-checkconf.c Thu Oct 20 21:59:47 2016
@@ -18,9 +18,6 @@
#include "dname.h"
#include "rrl.h"

-extern char *optarg;
-extern int optind;

2

Hi Jan,

Yes, that is the case. That is for portability.

If it somehow a problem on systems, it would receive #ifdefs around
it, but it does not seem to give warnings.

Best regards, Wouter

3

> The following source files in the 4.1.3 tarball declare extern int
> optind and extern char* optarg, but those are already declared in
> the headers. (Or is there a system where this is not the case?)

Yes, that is the case. That is for portability.

Can you please give an example of a system where this is a problem,
i.e. where the opt* are _not_ already declared in the headers?

  Thank you

    Jan