This is the pre-release of release candidate 1, for package
maintainers and build issues. If there are no issues, the full
release is planned next week.
This release has a bunch of bug fixes after John Van de Meulebrouck
Brendgard reported a slew of crashes in the zone parser. There are
also integer overflow in allocation fixes, with an implementation of
reallocarray, contributed by Loganaden Velvindron. And there are
small statistics reporting additions for zone update notifications.
This is the pre-release of release candidate 1, for package
maintainers and build issues. If there are no issues, the full
release is planned next week.
I just built it on our CentOS 6 build box, and there were no errors.
There were just some warnings (gcc 4.4.7):
xfrd-tcp.c: In function 'pipeline_find':
xfrd-tcp.c:235: warning: dereferencing pointer 'key' does break
strict-aliasing rules
xfrd-tcp.c:233: warning: dereferencing pointer 'key' does break
strict-aliasing rules
xfrd-tcp.c:223: warning: dereferencing pointer 'key' does break
strict-aliasing rules
xfrd-tcp.c:222: warning: dereferencing pointer 'key' does break
strict-aliasing rules
xfrd-tcp.c:221: warning: dereferencing pointer 'key' does break
strict-aliasing rules
ipc.c: In function 'child_handle_parent_command':
ipc.c:85: warning: ignoring return value of 'write', declared with
attribute warn_unused_result
zonec.c: In function 'zparser_conv_loc':
zonec.c:956: warning: ignoring return value of 'strtol', declared with
attribute warn_unused_result
I just built it on our CentOS 6 build box, and there were no errors.
There were just some warnings (gcc 4.4.7):
xfrd-tcp.c: In function 'pipeline_find':
xfrd-tcp.c:235: warning: dereferencing pointer 'key' does break strict-aliasing rules
xfrd-tcp.c:233: warning: dereferencing pointer 'key' does break strict-aliasing rules
xfrd-tcp.c:223: warning: dereferencing pointer 'key' does break strict-aliasing rules
xfrd-tcp.c:222: warning: dereferencing pointer 'key' does break strict-aliasing rules
xfrd-tcp.c:221: warning: dereferencing pointer 'key' does break strict-aliasing rules
ipc.c: In function 'child_handle_parent_command':
ipc.c:85: warning: ignoring return value of 'write', declared with attribute warn_unused_result
zonec.c: In function 'zparser_conv_loc':
zonec.c:956: warning: ignoring return value of 'strtol', declared with attribute warn_unused_result
I build for Debian squeeze/wheezy/jessie. same warnings, installed & running ...
but I found some points I find ... at least strange:
I have one nsd as master, a second as slave receiving data via zone transfers.
- @master: nsd-control stop ( and restart )
- log @slave:
info: notify for example.org. from 2001:db8::53 serial 1234
- @master: nsd-control notify
- log @slave:
info: notify for example.org. from 2001:db8::53
- log @master:
failed reading from 2001:db8::153 tcp: Connection reset by peer
failed writing to tcp: Connection reset by peer
( multiple times ...)
in both cases the serial number @master did not change.
This is the same as RC1 but with small changes to logging levels that
make the verbosity level 1 logs have more brevity, but still log
notifications and zone transfers. The verbosity 2 logs contain the
removed detail.
BUG FIXES (additional in RC2):
- - Made log message more consistent, changed 'axfr refused' log message
to be more consistent with other messages. Also notify refused.
- - verbosity 2 logs axfr refused and notify refused.
verbosity 1 contains less log messages.
I can confirm that it builds and runs just fine on our CentOS 6 servers.
This is the same as RC1 but with small changes to logging levels
that make the verbosity level 1 logs have more brevity, but still
log notifications and zone transfers. The verbosity 2 logs contain
the removed detail.
These changes are perfect. I now have "verbosity: 1" in our config
file, and it logs incoming notify and xfr messages, and there is no
clutter related to TCP disconnections.
This release has a bunch of bug fixes after John Van de
Meulebrouck Brendgard reported a slew of crashes in the zone
parser. There are also integer overflow in allocation fixes, with
an implementation of reallocarray, contributed by Loganaden
Velvindron. And there are small statistics reporting additions for
zone update notifications.
Also small changes to logging levels that make the verbosity level 1
logs have more brevity, but still log notifications and zone
transfers. The verbosity 2 logs contain the removed detail.
FEATURES:
- - Incoming notifies have serial number logged (at verbosity 1).
BUG FIXES:
- - Remove some duplicate header includes (from Brad Smith).
- - Fix tcp waiting list for zone transfers where the bind and connect
calls fail.
- - Fix segfault in zone reader on invalid input (thanks John Van de
Meulebrouck Brendgard)
- - Fix segfault on double origin in zone reader (thanks John Van de
Meulebrouck Brendgard).
- - Fix b64pton out of bounds error on invalid zonefile input.
(thanks John Van de Meulebrouck Brendgard)
- - Fix origin directive from unused old value and subdomain parser
failure, reported by John Van de Meulebrouck Brendgard.
- - Fix use after free after zonefile syntax error followed by ttl
or origin directive, reported by John Van de Meulebrouck Brendgard.
- - Fix syntax error followed by too many TXT elements parse crash
reported by John Van de Meulebrouck Brendgard.
- - Fix buffer overflow in config parse of domain name,
reported by John Van de Meulebrouck Brendgard.
- - Use reallocarray for integer overflow protection, patch submitted
by Loganaden Velvindron.
- - Fix allocation integer overflow checks.
- - Fix #654: Fix contradiction in notify logging verbosity level.
- - Fix #655: Fix contradiction in verbosity for zone transfers.
- - Made log message more consistent, changed 'axfr refused' log message
to be more consistent with other messages. Also notify refused.
- - verbosity 2 logs axfr refused and notify refused.
verbosity 1 contains less log messages.