RE: unbound-1.13.0RC3 pre-release

Hi Wouter,

Sorry, Managed to crash it again:

28/11/2020 16:07:39 C:\Program Files\Unbound\unbound.exe[1712:2] query: 127.0.0.1 1.1.1.141.in-addr.arpa. PTR IN
28/11/2020 16:07:39 C:\Program Files\Unbound\unbound.exe[1712:2] query: 127.0.0.1 18.109.32.154.in-addr.arpa. PTR IN
28/11/2020 16:07:39 C:\Program Files\Unbound\unbound.exe[1712:2] query: 127.0.0.1 1.0.0.1.origin.asn.cymru.com. TXT IN
28/11/2020 16:07:39 C:\Program Files\Unbound\unbound.exe[1712:2] query: 127.0.0.1 4.2.2.4.test.senderbase.org. TXT IN
28/11/2020 16:07:39 C:\Program Files\Unbound\unbound.exe[1712:2] reply: 127.0.0.1 1.0.0.1.origin.asn.cymru.com. TXT IN NOERROR 0.125024 0 103
28/11/2020 16:07:39 C:\Program Files\Unbound\unbound.exe[1712:2] query: 127.0.0.1 249.27.1.141.test.senderbase.org. TXT IN
28/11/2020 16:07:39 C:\Program Files\Unbound\unbound.exe[1712:2] query: 127.0.0.1 as13335.asn.cymru.com. TXT IN
28/11/2020 16:07:39 C:\Program Files\Unbound\unbound.exe[1712:2] query: 127.0.0.1 178.40.6.62.test.senderbase.org. TXT IN
28/11/2020 16:07:40 C:\Program Files\Unbound\unbound.exe[1712:2] query: 127.0.0.1 1.71.154.156.test.senderbase.org. TXT IN
28/11/2020 16:07:40 C:\Program Files\Unbound\unbound.exe[1712:2] query: 127.0.0.1 1.1.1.1.origin.asn.cymru.com. TXT IN
28/11/2020 16:07:40 C:\Program Files\Unbound\unbound.exe[1712:2] query: 127.0.0.1 42.42.82.74.test.senderbase.org. TXT IN
28/11/2020 16:07:40 C:\Program Files\Unbound\unbound.exe[1712:2] fatal error: services/outside_network.c:2596: serviced_callbacks: assertion rem failed

28/11/2020 16:13:48 C:\Program Files\Unbound\unbound.exe[9048:0] query: 127.0.0.1 148.98.215.64.test.senderbase.org. TXT IN
28/11/2020 16:13:48 C:\Program Files\Unbound\unbound.exe[9048:2] query: 127.0.0.1 114.0.72.194.test.senderbase.org. TXT IN
28/11/2020 16:13:48 C:\Program Files\Unbound\unbound.exe[9048:2] query: 127.0.0.1 1.1.1.1.origin.asn.cymru.com. TXT IN
28/11/2020 16:13:48 C:\Program Files\Unbound\unbound.exe[9048:0] query: 127.0.0.1 22.71.154.156.test.senderbase.org. TXT IN
28/11/2020 16:13:48 C:\Program Files\Unbound\unbound.exe[9048:2] query: 127.0.0.1 6.2.2.4.test.senderbase.org. TXT IN
28/11/2020 16:13:48 C:\Program Files\Unbound\unbound.exe[9048:0] query: 127.0.0.1 249.27.1.141.test.senderbase.org. TXT IN
28/11/2020 16:13:48 C:\Program Files\Unbound\unbound.exe[9048:0] fatal error: services/outside_network.c:2596: serviced_callbacks: assertion rem failed

28/11/2020 16:16:12 C:\Program Files\Unbound\unbound.exe[2852:0] query: 127.0.0.1 18.107.32.154.test.senderbase.org. TXT IN
28/11/2020 16:16:12 C:\Program Files\Unbound\unbound.exe[2852:3] query: 127.0.0.1 250.35.250.129.test.senderbase.org. TXT IN
28/11/2020 16:16:12 C:\Program Files\Unbound\unbound.exe[2852:3] query: 127.0.0.1 3.2.2.4.test.senderbase.org. TXT IN
28/11/2020 16:16:13 C:\Program Files\Unbound\unbound.exe[2852:3] query: 127.0.0.1 3.240.43.158.test.senderbase.org. TXT IN
28/11/2020 16:16:13 C:\Program Files\Unbound\unbound.exe[2852:0] query: 127.0.0.1 178.40.6.62.test.senderbase.org. TXT IN
28/11/2020 16:16:13 C:\Program Files\Unbound\unbound.exe[2852:0] query: 127.0.0.1 3.240.43.158.in-addr.arpa. PTR IN
28/11/2020 16:16:13 C:\Program Files\Unbound\unbound.exe[2852:0] fatal error: services/outside_network.c:2596: serviced_callbacks: assertion rem failed

Ray

Hi RayG,

Thanks for the debug output! I think I have a fix here, and a snapshot
compile for rc3+fix can be found here:
https://nlnetlabs.nl/~wouter/unbound-1.13.0_20201130.tar.gz
https://nlnetlabs.nl/~wouter/unbound-1.13.0_20201130.zip
https://nlnetlabs.nl/~wouter/unbound_setup_1.13.0_20201130.exe
And also .asc files with pgp signatures and .sha256 files.

The issue is when there is a double callback because a reuse stream is
not reused when a query that is not waiting is removed because of a lack
of interest from the iterator module, I fixed that double callback.

Best regards, Wouter