NSD zonec performance patches

NSD
1

Hi Martin,

I have looked at your patches and they look good. Here is what I did
with them:

- - I have applied the b64_pton patch without modification.

- - I have made the mmap patch configurable. You can enable it at build
time, with --enable-mmap. I have marked it experimental. By default off.

- - I have applied the parse-token-leaks patch the way it is.

- - I did not do the adaptive-rrtype-lookup patch. It changes lookup
behavior in favor of frequently used rrtypes. However, it's not clear to
me if this benefit the future lookups in all cases. In some cases it
might perform worse (for example zones sorted on rrtype).

The applied patches are now in trunk. Before releasing, they will
undergo another round of reviewing.

Thank you very much for your effort!

Best regards,

Matthijs

Martin Svec wrote:

2

Hi Matthijs,

thank you for accepting the patches. In these days we finalize a migration of our nameservers from Bind9 to NSD. There are still some problems with NSD for domain service providers like us, but Bind9 has its own problems too -- and I really like the clean and simple design of NSD :-). I send our remarks and suggestions to the list as soon as our nameservers will be successfully switched to NSD. (And maybe more patches, I have at least two now -- one that disables xfrd daemon and the other that aggregates bind8 stats over all server processes.)

Best regards
Martin

Matthijs Mekking napsal(a):