Nsd v4.3.5 treats long used DKIM line as syntax error

NSD
1

When I upgraded from nsd v4.3.4 to v4.3.5, nsd-checkzone(8) started
flagging errors in my zone files for DKIM lines that had been there for
many years.

Here's roughly what the line looks like:

    example._domainkey IN TXT ( "v=DKIM1; k=rsa; " "p=ZvtSzN0TPFdTFVo3QDRONDHNN4TANQPOvDXOtDDAqEOEObihifWVD095LxDXbSYILzbHBWCPuPzhzzxlS+tnLcTe+VcpZrh4TkFxym+++nZ8tBL1aR1agdd27lmo2GmRc84gXJUIlqu4Ml0TL/Ifxsuc4pJxD9sOO4FotjBnyTUI8wn3rWD5bVBjWzzLDr0ioP8W67TSxGblDmjhA//9WidNDNO")

(Values have been changed to protect the innocent.)

Is there some syntax error in the above line, or is this a bug?

FWIW, I'm running on FreeBSD 12.2, and here's the output from nsd:

    $ nsd-checkzone example.org example.org.m4
    [2021-03-08 12:13:18.298] nsd-checkzone[96109]: error: example.org.m4:124: syntax error
    zone example.org file example.org.m4 has 1 errors

Thomas

2

https://github.com/NLnetLabs/nsd/issues/154

3

https://github.com/NLnetLabs/nsd/issues/154

4

Hi Thomas,

It's a known (and still open) issue:

https://github.com/NLnetLabs/nsd/issues/154

Regards,
Anand

5

Oh, and you can workaround by removing the parens (you don't need them
if the multiple parts of the record are on a single line in the zone file).

btw, OpenBSD has avoided updating to NSD 4.3.5 in base because of this.

6

* Stuart Henderson <stu@spacehopper.org> [2021-03-09 08:31:44+0000]:

> > When I upgraded from nsd v4.3.4 to v4.3.5, nsd-checkzone(8)
> > started flagging errors in my zone files for DKIM lines that had
> > been there for many years.
>
> https://github.com/NLnetLabs/nsd/issues/154

Oh, and you can workaround by removing the parens (you don't need them
if the multiple parts of the record are on a single line in the zone file).

Ah, thank you for this. I'll probably stick with v4.3.4 for a bit
longer, but this is good to know.

Thomas

7

* Anand Buddhdev <anandb@ripe.net> [2021-03-09 09:27:55+0100]:

> When I upgraded from nsd v4.3.4 to v4.3.5, nsd-checkzone(8) started
> flagging errors in my zone files for DKIM lines that had been there for
> many years.

It's a known (and still open) issue:
https://github.com/NLnetLabs/nsd/issues/154

Thank you, I should have looked through the bug db first.

Thomas

8

If all is well this has been resolved with the merge of [PR#164](
https://github.com/NLnetLabs/nsd/pull/164). Can you confirm the current
master branch fixes these issues? Thanks!
-- Willem

9

Thanks Willem, confirmed this fixes the problem I had.

10

* Willem Toorop <willem@nlnetlabs.nl> [2021-03-13 21:11:51+0100]:

If all is well this has been resolved with the merge of [PR#164](
https://github.com/NLnetLabs/nsd/pull/164). Can you confirm the current
master branch fixes these issues? Thanks!

I had some issues compiling directly from master, apparently because of
commit 6e2071 ("Repair -fno-common linker errors automatically.") --
clang complained about the missing "configyyrename.h" header.

When I reverted that single commit I was able to build the rest fine
and verified that nsd-checkzone worked correctly with my existing zone
files.

Thomas

11

* Willem Toorop <willem@nlnetlabs.nl> [2021-03-13 21:11:51+0100]:

If all is well this has been resolved with the merge of [PR#164](
https://github.com/NLnetLabs/nsd/pull/164). Can you confirm the current
master branch fixes these issues? Thanks!

I had some issues compiling directly from master, apparently because of
commit 6e2071 ("Repair -fno-common linker errors automatically.") --
clang complained about the missing "configyyrename.h" header.

Interesting! That's valuable feedback! Thanks!

-- Willem