Nsd patch does not return proper failure code?

NSD
1

-bash-3.2$ sudo /usr/sbin/nsdc -c /etc/nsd/nsd.conf patch
reading database
[1269816112] nsd-patch[12113]: error: cannot load database. Zone rfc4322.org. in db /var/lib/nsd/nsd.db, but not in config file (might happen if you edited the config file). Please rebuild database and start again.
could not read database: /var/lib/nsd/nsd.db
nsdc: patch failed.
-bash-3.2$ echo $?
0

I would expect a non-zero error code. I confirmed that sudo in other error cases
does return a proper error code.

Paul

2

Hi Paul,

do_patch() will return a non-zero error code, however, the echo "failed"
overrides that. I have added an explicit return 1 in this case (in trunk).

Thanks!

Matthijs

Paul Wouters wrote: